fix: Explicitly set rustls provider before using rustls #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Hey,
Did you try specifying ring = { version = *, default-features = false, features = ["ring", "logging", "std", "tls12"] } in jsonrpsee to fix it?
Or is this the case that some other crate brings in aws-ls-rs and rustls priorities aws-lc-rc when both ring and aws-ls-rc are defined?
Anyway, I'm fine with this hack.
Yes, I had both |
jsdw
approved these changes
Jul 29, 2024
|
Thanks @popzxc, we'll release a new version tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently
rustlschanged default crypto provider fromringtoaws-lc-rs, and it caused some crates to depend on both features (e.g. if one dependency uses a default provider, and other one enablesring).In such cases,
rustlswould panic, because it can't choose a default provider (see this issue).This PR makes sure that the provider is set before using
rustlsfunctionality, thus preventing panics in runtime.This isn't the most elegant solution to the problem, but it does fix it (confirmed in my project), so I hope it's fine to merge it as a quickfix.